-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/parse only single file #187
base: main
Are you sure you want to change the base?
Feat/parse only single file #187
Conversation
|
||
const program = new Command() | ||
.requiredOption('-d, --directory <string>', 'Directory to migrate') | ||
.option('-d, --directory <string>', 'Directory to migrate. Either directory or file should be provided, not both or none.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OptionParser
guarantees option requirements
Hello, thank you for such an awesome project. Would you please review this feature request? |
Thanks a lot for the PR, I just added a comment, the rest looks good to me. |
Thank you checking my PR. Sorry but, I cannot see where your comment is. Did you leave comment on the code diff? |
Co-authored-by: Victor Cuena Garcia <[email protected]>
Thanks alot for your review! I fixed it, would you please review this again? |
Overview
This is a feature request.
Our project appreciates this awesome project, because its has so many class style components.
By the way, we want to migrate
.vue
file one by one checking passing unit tests.So, this feature request proposes that
vue-class-migrator
can parse CLI option-f
same as-d
.Design
vue-class-migrator...
migrate function
of entry pointOptionParser
class to force option selectionChecks
I checked that...
-f
option works