-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add LangGraph example, remove LangServe example, and update deps #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 9637ed2 in 15 seconds
More details
- Looked at
665
lines of code in10
files - Skipped
4
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. pyproject.toml:25
- Draft comment:
Ensure that thelangchain-openai
dependency version^0.1.23
is compatible with other dependencies and necessary for the project. - Reason this comment was not posted:
Confidence changes required:50%
Thepyproject.toml
file in the root directory has been updated with new dependencies. It's important to ensure that these dependencies are necessary and correctly versioned.
2. pyproject.toml:26
- Draft comment:
Ensure that thelanggraph
dependency version^0.2.16
is compatible with other dependencies and necessary for the project. - Reason this comment was not posted:
Confidence changes required:50%
Thepyproject.toml
file in the root directory has been updated with new dependencies. It's important to ensure that these dependencies are necessary and correctly versioned.
3. pyproject.toml:27
- Draft comment:
Ensure that theipywidgets
dependency version^8.1.5
is compatible with other dependencies and necessary for the project. - Reason this comment was not posted:
Confidence changes required:50%
Thepyproject.toml
file in the root directory has been updated with new dependencies. It's important to ensure that these dependencies are necessary and correctly versioned.
4. pyproject.toml:28
- Draft comment:
Ensure that theopenai
dependency version^1.43.0
is compatible with other dependencies and necessary for the project. - Reason this comment was not posted:
Confidence changes required:50%
Thepyproject.toml
file in the root directory has been updated with new dependencies. It's important to ensure that these dependencies are necessary and correctly versioned.
5. pyproject.toml:29
- Draft comment:
Ensure that thenotebook
dependency version^7.2.2
is compatible with other dependencies and necessary for the project. - Reason this comment was not posted:
Confidence changes required:50%
Thepyproject.toml
file in the root directory has been updated with new dependencies. It's important to ensure that these dependencies are necessary and correctly versioned.
Workflow ID: wflow_wL5qvpkmL5Y6jtbv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Co-authored-by: fern-api <115122769+fern-api[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on a79a272 in 10 seconds
More details
- Looked at
93
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. src/zep_cloud/langchain/history.py:100
- Draft comment:
Avoid using# type: ignore
unless absolutely necessary, as it can hide potential issues. Ensure that the deprecated code is still functioning as expected. - Reason this comment was not posted:
Confidence changes required:50%
The code uses# type: ignore
comments, which can hide potential issues. It's important to ensure these are necessary and not masking real problems.
Workflow ID: wflow_hIoY1vBmsIRlEufE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Remove
langchain-langserve
example, addLangGraph
example, and update dependencies inpyproject.toml
.langchain-langserve
example, including files likeREADME.md
,app/ingest.py
, andapp/server.py
.LangGraph
example.langchain-openai
to^0.1.23
.langgraph
version^0.2.16
.ipywidgets
version^8.1.5
.openai
to^1.43.0
.notebook
version^7.2.2
.This description was created by
for a79a272. It will automatically update as commits are pushed.