-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #227
Merged
Merged
V2 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to d77b775 in 40 seconds
More details
- Looked at
106
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. examples/chat_history/memory.py:79
- Draft comment:
Consider whether the increased sleep duration from 20 to 50 seconds is necessary. If processing time is an issue, it might be worth investigating performance improvements. - Reason this comment was not posted:
Confidence changes required:50%
The sleep duration was increased from 20 to 50 seconds, which might be necessary for processing but could also indicate a performance issue.
2. src/zep_cloud/types/memory.py:21
- Draft comment:
Thefacts
field is marked as deprecated. Consider usingrelevant_facts
instead to future-proof the code. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_G0cNhM8uu5DnS2HL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
context
field toMemory
class, update version to 2.1.0, and modify example script inmemory.py
.context
field toMemory
class inmemory.py
to store session-related facts and entities.2.1.0
inpyproject.toml
andclient_wrapper.py
.memory.py
to log user and session creation.memory.py
.This description was created by for d77b775. It will automatically update as commits are pushed.