Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #227

Merged
merged 11 commits into from
Nov 6, 2024
Merged

V2 #227

merged 11 commits into from
Nov 6, 2024

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Nov 6, 2024

Important

Add context field to Memory class, update version to 2.1.0, and modify example script in memory.py.

  • Memory Class:
    • Add context field to Memory class in memory.py to store session-related facts and entities.
  • Version Update:
    • Update version to 2.1.0 in pyproject.toml and client_wrapper.py.
  • Example Script:
    • Add print statements in memory.py to log user and session creation.
    • Increase sleep duration from 20 to 50 seconds in memory.py.

This description was created by Ellipsis for d77b775. It will automatically update as commits are pushed.

@paul-paliychuk paul-paliychuk merged commit 8226d9a into main Nov 6, 2024
3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d77b775 in 40 seconds

More details
  • Looked at 106 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. examples/chat_history/memory.py:79
  • Draft comment:
    Consider whether the increased sleep duration from 20 to 50 seconds is necessary. If processing time is an issue, it might be worth investigating performance improvements.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The sleep duration was increased from 20 to 50 seconds, which might be necessary for processing but could also indicate a performance issue.
2. src/zep_cloud/types/memory.py:21
  • Draft comment:
    The facts field is marked as deprecated. Consider using relevant_facts instead to future-proof the code.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_G0cNhM8uu5DnS2HL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant