Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support hex encoded keys instead of mnemonic #47

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

support hex encoded keys instead of mnemonic #47

wants to merge 1 commit into from

Conversation

trusch
Copy link
Collaborator

@trusch trusch commented Feb 18, 2025

No description provided.

@trusch trusch requested review from aleasims and miax-gevu February 18, 2025 13:02
aleasims
aleasims approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@aleasims aleasims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems with this.

Just a note: I don't understand, why signer is a private module. E.g. public BaseClient has a public method set_signer, which is impossible to call, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleasims aleasims aleasims approved these changes

@miax-gevu miax-gevu Awaiting requested review from miax-gevu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trusch @aleasims