This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Report error from submit_file() in shim
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an error occurs during file transfer from VM to node, an error should be reported from the function to higher level so that the program and VM can terminate deterministically.
musitdev
reviewed
Mar 7, 2024
There was a problem hiding this comment.
I've done the same change during my tests but differently:
main...transfert_big_files
I think both work, but in mine there's no Mutex.
I think your solution is a lot better. I switched to that. |
|
I recon this is ok to merge since it works and the original code is from you @musitdev ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error occurs during file transfer from VM to node, an error should be reported from the function to higher level so that the program and VM can terminate deterministically.