This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Add created_at timestamp to transaction
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transaction creation timestamp can be used for categorizing historical transactions in to an immutable set that can be then used for syncing. In Gevulot devnet, since there is no consensus, there is also no reliable way to order transactions correctly in a distributed system. However, when each transaction still has a creation timestamp, that can be used as a snapshotting point where all historical transactions can be ordered by their hash and therefore grouped for quicker syncing.
|
😠 I just found out I've been sitting on this over a month. I thought it was already in |
musitdev
approved these changes
Mar 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction creation timestamp can be used for categorizing historical transactions in to an immutable set that can be then used for syncing.
In Gevulot devnet, since there is no consensus, there is also no reliable way to order transactions correctly in a distributed system.
However, when each transaction still has a creation timestamp, that can be used as a snapshotting point where all historical transactions can be ordered by their hash and therefore grouped for quicker syncing.