This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Change Tx validation logic to add: Tx wait that its parent has been validated. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuommaki
reviewed
Mar 13, 2024
| @@ -202,3 +273,275 @@ impl TxEvent<NewTx> { | |||
| .await | |||
| } | |||
| } | |||
|
|
|||
| // Use to cache New tx and store waiting Tx that have missing parent. | |||
| pub struct TXCache { | |||
There was a problem hiding this comment.
Should this possibly be named TxCache so that it's aligned with other types (e.g. TxEvent or WaitTx etc.)?
| ) | ||
| } | ||
| pub fn build(cache_size: usize, max_waiting_tx: usize, max_waiting_time: u64) -> Self { | ||
| let cachedtx_for_verification = |
There was a problem hiding this comment.
Suggested change
| let cachedtx_for_verification = | |
| let cached_tx_for_verification = |
Would it be ok to separate the words like this so it's easier to read when skimming the code through?
There was a problem hiding this comment.
I've updated all occurrences in the code.
| let tx_hash = tx_event.tx.hash; | ||
| let res = tx_event.process_event(&mut wait_tx_cache, &db).await; | ||
| assert!(res.is_ok()); | ||
| // Evicted but new ket added. |
crates/node/src/txvalidation/mod.rs
Outdated
| Ok(new_tx_list) => { | ||
| // | ||
| let jh = tokio::spawn({ | ||
| let newtx_receiver = newtx_receiver.clone(); |
There was a problem hiding this comment.
Maybe these could also be renamed to new_tx_receiver for easier readability?
Co-authored-by: Tuomas Mäkinen <[email protected]>
Co-authored-by: Tuomas Mäkinen <[email protected]>
|
I've applied the changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Child Tx must be executed after its parent if it has a parent Tx.
This order is not guaranteed by the current code and can easily arrive when Proof has a big file as input. The child verify Tx can be executed during the proof input file download.
After Tx verification, the Tx's parent, if it exists, is verified to be already validated.
To do that, the presence of the parent Tx in the db is verified. A cache is used to avoid Db query of the recent Tx.
If the parent is not found, the Tx is put in a waiting list.
When the parent arrives, the child Tx are removed from the waiting list and added to the mempool with the parent tx.
The process_event logic code is more complex because I wanted to avoid using a mutex for the cache, and we need to mix sync code (cache / waiting Tx verification) and async one.
I set it in draft because to be fully tested, the PE #136 must be merged to be able to test it with bigfile.