This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Handle P2P discovery connection error #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the initial discovery nodes cannot be connected, handle the error correctly. If no discovery nodes respond, then terminate the program.
tuommaki
commented
Mar 14, 2024
| @@ -281,6 +290,13 @@ async fn run(config: Arc<Config>) -> Result<()> { | |||
| } | |||
| } | |||
|
|
|||
| // If we couldn't connect to any P2P nodes, we'll be left out alone forever. | |||
| // Useless to run at that point. | |||
| if !config.p2p_discovery_addrs.is_empty() && connected_nodes == 0 { | |||
There was a problem hiding this comment.
For the P2P bootstrap node, the discovery addresses are empty as that's the beacon of the network. In that case it's fine that connected_nodes == 0. For the others: It's useless to continue when no friends are playing with. 🙂
musitdev
approved these changes
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the initial discovery nodes cannot be connected, handle the error correctly. If no discovery nodes respond, then terminate the program.