This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Move rest of the locks to SchedulerState
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Scheduler` had at least one more deadlock hiding in it's code. Most probably it was the `ProgramManager`. Moving both, the `mempool` and `program_manager` to `SchedulerState` doesn't reveal the deadlock anymore.
|
Going with this to get a build for devnet operators still today. @musitdev Please still check the diff and give me a shout if you think there are any issues with this. |
|
I don't think that putting together the mutex will solve it. It just changes the probability to see it. We'll see in production, but it can be very annoying because silent deadlock become visible when the load increases. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schedulerhad at least one more deadlock hiding in it's code. Most probably it was theProgramManager. Moving both, themempoolandprogram_managertoSchedulerStatedoesn't reveal the deadlock anymore.