This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Don't recovery non-executed txs on startup #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has turned out in practice that nodes are unable to re-execute old non-executed transactions on startup. It often happens that nodes are running long time without restart and when they do, they start to re-execute transactions from several days / weeks behind, which doesn't make any sense. Therefore drop the pickup of non-executed transactions on startup and continue from the latest "HEAD".
|
YOLO; CI green. Going. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has turned out in practice that nodes are unable to re-execute old non-executed transactions on startup. It often happens that nodes are running long time without restart and when they do, they start to re-execute transactions from several days / weeks behind, which doesn't make any sense.
Therefore drop the pickup of non-executed transactions on startup and continue from the latest "HEAD".