Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Set limits to PgPool #33

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Set limits to PgPool #33

merged 1 commit into from
Jan 12, 2024

Conversation

tuommaki
Copy link
Contributor

  • Maximum number of connections (64).
  • Connection timeout (750ms).

@tuommaki
Set limits to PgPool
932554b 
- Maximum number of connections (64).
- Connection timeout (750ms).
@tuommaki tuommaki self-assigned this Jan 12, 2024
tuommaki
tuommaki commented Jan 12, 2024
View reviewed changes
crates/node/src/storage/database/postgres.rs
Comment on lines +10 to +11
const MAX_DB_CONNS: u32 = 64;
const DB_CONNECT_TIMEOUT: Duration = Duration::from_millis(750);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit undecided whether or not these should be configurable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll decide when you'll need to configure it. It's easy to add some configuration and use these as default value when needed. If you don't have a good reason for now, let the things like that.

@tuommaki tuommaki requested a review from musitdev January 12, 2024 12:58
@tuommaki tuommaki merged commit a483ddc into proto Jan 12, 2024
4 checks passed
@tuommaki tuommaki deleted the set-pgpool-limits branch January 12, 2024 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@musitdev musitdev musitdev approved these changes

Assignees

@tuommaki tuommaki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuommaki @musitdev