fix: move 0-dimension check for transfers to be after validation #5362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
0-dimension-transfers
branch
2 times, most recently
from
a3a24d9
to
1746ebe
Compare
ErichDonGubler
force-pushed
the
0-dimension-transfers
branch
from
1746ebe
to
60cf6db
Compare
ErichDonGubler
force-pushed
the
0-dimension-transfers
branch
from
60cf6db
to
aad14de
Compare
ErichDonGubler
force-pushed
the
0-dimension-transfers
branch
from
aad14de
to
e504e14
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
changed the title
ErichDonGubler
commented
May 31, 2024
Comment on lines
-707
to
-641
| if size == 0 { | ||
| log::trace!("Ignoring copy_buffer_to_buffer of size 0"); | ||
| return Ok(()); | ||
| } | ||
|
|
There was a problem hiding this comment.
issue: This and the other hunk should be moved, not removed.
ErichDonGubler
force-pushed
the
0-dimension-transfers
branch
from
e504e14
to
b350e77
Compare
ErichDonGubler
force-pushed
the
0-dimension-transfers
branch
2 times, most recently
from
732f2dd
to
2e5625d
Compare
ErichDonGubler
force-pushed
the
0-dimension-transfers
branch
2 times, most recently
from
ddee32c
to
1a46142
Compare
ErichDonGubler
force-pushed
the
0-dimension-transfers
branch
from
1a46142
to
1d2a422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Discovered with Firefox's bug 1848866.
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.