-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement F16 support in shaders #5701
base: trunk
Are you sure you want to change the base?
Conversation
I've marked this as ready for review, as the wgpu specific logic is implemented and would be great to start iterating on it. 2 main blockers are:
|
Dogfooding works! Fixed a few bugs in 30e12b5. Still waiting on upstream. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
One thing I'm concerned is that the polyfills we have in some of the backends might not support |
This comment was marked as resolved.
This comment was marked as resolved.
9c6a9b3
to
9f33e0e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
493e740
to
01bc1bd
Compare
Restored ownership of the commit, sorry about that :) |
man it's happening, let's go! ❤️ @cwfitzgerald @ErichDonGubler please lemme know if i can help somehow |
# Conflicts: # naga/Cargo.toml
68ac734
to
efb441d
Compare
Connections
enable …;
that reports nice errors #6424.enable
directive #5476.Checklist for merge-ability
hexf_parse f16 support: https://github.com/lifthrasiir/hexf. This one won't be fun. Did some work on it here: lifthrasiir/hexf@master...FL33TW00D:hexf:feature/f16 .Deferred to Implement Parsing of Hexadecimal F16 #7046f16
inside push constants.Additional context
F16 is available in >=SM6.2: https://github.com/microsoft/DirectXShaderCompiler/wiki/16-Bit-Scalar-Types