Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse diagnostic(…) attributes on fns #6353

Draft
wants to merge 13 commits into
base: trunk
Choose a base branch
from

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Oct 1, 2024

Connections

Description

Building on #6148, we use all of the plumbing we made for tracking diagnostic rules, and add a parse path for @diagnostic(…) fn function() { … }. After #6148, this PR's parse path is what I've observed to be the next most common place for users to apply diagnostic filtering.

Testing

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-xlypklnukzlu branch from bf4eab8 to a954d89 Compare October 3, 2024 20:25
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-xlypklnukzlu branch 11 times, most recently from 3039803 to 6479c1d Compare October 18, 2024 16:40
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-xlypklnukzlu branch 14 times, most recently from 9b6f777 to 319229a Compare October 25, 2024 18:32
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-xlypklnukzlu branch 2 times, most recently from 05f8ba6 to 8a3e747 Compare October 26, 2024 01:10
@ErichDonGubler ErichDonGubler self-assigned this Oct 29, 2024
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-xlypklnukzlu branch 13 times, most recently from 50e4a8d to fd9851a Compare November 5, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Support diagnostic filters in WGSL (i.e., diagnostic(…))
1 participant