-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse diagnostic(…)
attributes on fn
s
#6353
Draft
ErichDonGubler
wants to merge
13
commits into
gfx-rs:trunk
Choose a base branch
from
erichdongubler-mozilla:erichdongubler/push-xlypklnukzlu
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Parse diagnostic(…)
attributes on fn
s
#6353
ErichDonGubler
wants to merge
13
commits into
gfx-rs:trunk
from
erichdongubler-mozilla:erichdongubler/push-xlypklnukzlu
+557
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
ErichDonGubler
force-pushed
the
erichdongubler/push-xlypklnukzlu
branch
from
October 3, 2024 20:25
bf4eab8
to
a954d89
Compare
ErichDonGubler
force-pushed
the
erichdongubler/push-xlypklnukzlu
branch
11 times, most recently
from
October 18, 2024 16:40
3039803
to
6479c1d
Compare
ErichDonGubler
force-pushed
the
erichdongubler/push-xlypklnukzlu
branch
14 times, most recently
from
October 25, 2024 18:32
9b6f777
to
319229a
Compare
ErichDonGubler
force-pushed
the
erichdongubler/push-xlypklnukzlu
branch
2 times, most recently
from
October 26, 2024 01:10
05f8ba6
to
8a3e747
Compare
ErichDonGubler
force-pushed
the
erichdongubler/push-xlypklnukzlu
branch
13 times, most recently
from
November 5, 2024 19:12
50e4a8d
to
fd9851a
Compare
This resolves ambiguity that will be introduced in the subsequent commit that adds `impl From<ConflictingDiagnosticRuleError> for naga::Error`.
ErichDonGubler
force-pushed
the
erichdongubler/push-xlypklnukzlu
branch
from
November 8, 2024 02:29
fd9851a
to
bca75a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
diagnostic(…);
directives #6148.diagnostic(…)
) #5320.Description
Building on #6148, we use all of the plumbing we made for tracking diagnostic rules, and add a parse path for
@diagnostic(…) fn function() { … }
. After #6148, this PR's parse path is what I've observed to be the next most common place for users to apply diagnostic filtering.Testing
webgpu:shader,validation,parse,diagnostic:valid_locations:*
…:type="attribute";location="function"
webgpu:shader,validation,parse,diagnostic:duplicate_attribute_same_location:*
webgpu:shader,validation,parse,diagnostic:conflicting_attribute_different_location:*
webgpu:shader,validation,parse,diagnostic:diagnostic_scoping:*
, specific case TBD.Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.