Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naga: add types to InvalidBinaryOperandTypes error msg #6450

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Naga: add types to InvalidBinaryOperandTypes error msg #6450

wants to merge 2 commits into from

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Oct 23, 2024 •
edited
Loading

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

Description
Describe what problem this is solving, and how it's solved.

Testing
Explain how this change is tested.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-vwpuonuxytrn branch 2 times, most recently from 39df922 to 04a2a1b Compare October 31, 2024 04:07
@ErichDonGubler ErichDonGubler marked this pull request as ready for review November 5, 2024 14:36
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner November 5, 2024 14:36
teoxoy
teoxoy approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ErichDonGubler ErichDonGubler self-assigned this Nov 5, 2024
@ErichDonGubler ErichDonGubler added type: enhancement New feature or request kind: diagnostics Error message should be better naga Shader Translator area: validation Issues related to validation, diagnostics, and error handling labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees

@ErichDonGubler ErichDonGubler

Labels
area: validation Issues related to validation, diagnostics, and error handling kind: diagnostics Error message should be better naga Shader Translator type: enhancement New feature or request
Projects
WebGPU for Firefox
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErichDonGubler @teoxoy