Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(naga): add coverage for diagnostic directive parsing #6457

Draft
wants to merge 10 commits into
base: trunk
Choose a base branch
from
Draft

test(naga): add coverage for diagnostic directive parsing #6457

wants to merge 10 commits into from
+575 −90

Commits on Nov 8, 2024

  1. refactor(wgsl-in): specify more closure ret. types in parsing 

    This resolves ambiguity that will be introduced in the subsequent commit
that adds `impl From<ConflictingDiagnosticRuleError> for naga::Error`.
    @ErichDonGubler
    ErichDonGubler committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0ec802c View commit details
    Browse the repository at this point in the history

  2. feat(wgsl-in): detect conflicting diag. filters

    @ErichDonGubler
    ErichDonGubler committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    39d4ddd View commit details
    Browse the repository at this point in the history

  3. chore: remove unimpl. diag. filt. err. check

    @ErichDonGubler
    ErichDonGubler committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    5f26bb3 View commit details
    Browse the repository at this point in the history

  4. refactor(wgsl-in): track diagnostic directives in func. analysis

    @ErichDonGubler
    ErichDonGubler committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    da8ceae View commit details
    Browse the repository at this point in the history

  5. feat(wgsl-in): filter unif. analysis errors with derivative_uniformity

    @ErichDonGubler
    ErichDonGubler committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ccd4adc View commit details
    Browse the repository at this point in the history

  6. refactor(naga)!: diagnostic_filter: s/{from,to}_ident/{from,to}_wgs… 

    …l_ident
    @ErichDonGubler
    ErichDonGubler committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    58f1790 View commit details
    Browse the repository at this point in the history

  7. move(naga)!: move WGSL-specific diagnostic_filter stuff to `naga::f… 

    …ront::wgsl`
    @ErichDonGubler
    ErichDonGubler committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    47a15bb View commit details
    Browse the repository at this point in the history

  8. docs(CHANGELOG): add entry for diagnostic(…) directives

    @ErichDonGubler
    ErichDonGubler committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    02daf28 View commit details
    Browse the repository at this point in the history

  9. SYNC POINT: resolve conflicts

    @ErichDonGubler
    ErichDonGubler committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    60ca467 View commit details
    Browse the repository at this point in the history

  10. test(naga): cover diagnostic(…); parsing

    @ErichDonGubler
    ErichDonGubler committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    3c78456 View commit details
    Browse the repository at this point in the history