tvdb may return multiple series #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where TheTVDB.com returns multiple entries *and* the series we
are looking for is not the first one, the series would not be found,
because only the first one would be checked.
In my case, I am looking for 'The Good Place' and TheTVDB.com returns
the following structure (in XML equivalent).
- Series
- SeriesName: The Good Place: The Podcast
- Series
- SeriesName: The Good Place
I am looking for the second one, but the loop stops at the first entry
when raising the ShowNotFoundException.
Solve this problem by raising the exception only when all series are
checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where TheTVDB.com returns multiple entries and the series we
are looking for is not the first one, the series would not be found,
because only the first one would be checked.
In my case, I am looking for 'The Good Place' and TheTVDB.com returns
the following structure (in XML equivalent).
I am looking for the second one, but the loop stops at the first entry
when raising the ShowNotFoundException.
Solve this problem by raising the exception only when all series are
checked.