Export typescript types #4077
Closed
Export typescript types #4077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another approach to export typescript type declarations in a way that can be consumed by every project out there.
Previous work based on @rollup/plugin-typescript` failed as type declarations were emitted with file extensions.
In this approach, we let typescript to emit both source and the declarations. But as typescript is incapable of changing the file extensions to
cjs, we force module resolution by adding special package.json files in the build output.This change forces us to use file extensions in all relative import, which may be a beneficial change as the ecosystem is moving to that standard anyways.