Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme updates #2089

Merged
merged 11 commits into from
Aug 19, 2024
Merged

Theme updates #2089

merged 11 commits into from
Aug 19, 2024

Conversation

jcollie
Copy link
Member

@jcollie jcollie commented Aug 12, 2024

Two patches:

  • Allow loading themes from
    • absolute path
    • subdirectory of user's config directory
  • Add a switch for showing a short preview of themes.

Screenshot from 2024-08-11 21-07-56

@mitchellh
Copy link
Contributor

mitchellh commented Aug 12, 2024

Awesome work. I did a refactor on how we search for themes and just pushed it up. I didn't test this at all. Can you take a look, run through it, and see if it works? And open to any feedback. My main goal was to simplify the loadTheme function a bit which was getting noisy, and to limit allocations in our happy path (at the expense of increasing allocations in our sad path).

I want to fully refactor out the themeDir function and enum in Config.zig to use the new one but I ran out of time tonight. Feel free to finish that if you want I think the direction I was going is pretty clear.

@mitchellh mitchellh merged commit 1fd9cf2 into ghostty-org:main Aug 19, 2024
17 of 19 checks passed
@mitchellh mitchellh deleted the theme-updates branch August 19, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants