-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gtk: implement sensitive content reveal on paste confirmation #6054
gtk: implement sensitive content reveal on paste confirmation #6054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in the start of the PR, need to get this working for Adwaita 1.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a UI design perspective I'm not sure if a background blur is idiomatic for GTK4 apps, although I'm not opposed to it. A separate row button is definitely not it, though... maybe an overlaid button in the corner could be used to reenable the overlay? I'm not sure why anyone would do this anyway.
The blur is sweet |
I like the blur as well, but I agree that a separate button isn't the right UI. Generally clicking on the blurred panel is what I see for UI. |
How about something like this? 2025-03-03.16-46-29.mp4I'm not really sure what to think about the hide button, it feels out of place in there, maybe it is actually not needed at all? |
Looks good!
Yeah, I'd just get rid of the hide button, and let clicking on the text view itself hide the content again. |
What about a button similar to a password entry. Just an 👁️ button overlaid in the top right corner (or top left corner) in LTR languages? |
This |
Ok, that looks perfect to me, but I'm open to any suggestions 😄 2025-03-03.19-26-39.mp4I'll address the rest of the required changes in the following days, since I don't have any more time for now. |
Looks good! |
For the overlay, I would add the |
…confirmation in secure input mode
- implement blueprints for Adwaita 1.2 - use postifx notation for casting gtk widgets - fix formatting
2f72b06
to
bd617c5
Compare
Ok, that should be the final version. I've Added the implemenation for Adwaita 1.2, addressed the other issues and resolved merge conflicts. |
Thanks @maciekbartczak for putting up with all our nitpicks, great work! |
Fixes #4947 for gtk
This PR implements the senstive content hiding when displaying the paste confirmation dialog in secure input mode.
Following changes are implemented:
secure_input
action value for each surface in the GTK apprtDemo:
2025-03-02.17-37-11.mp4
I feel like this is already a nearly full implementation, but I'm leaving this as a draft for now, since i need to look into blueprints for Adwaita 1.2, and verify if it behaves properly when the dialog is in not-sensitive input mode and in OSC52 mode.