implement Phoenix.HTML.Safe protocol #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a struct for the
PhoenixImportmap.Importmap
module that implements thePhoenix.HTML.Safe
protocol discussed in #4.By using the protocol, we signal to the user that the return value of
PhoenixImportmap.importmap/1
is safe to inject into the template.Changes made in this PR
:phoenix_html
as a dependency.PhoenixImportmap.Importmap
module.%PhoenixImportmap.Importmap{}
.PhoenixImportmap.importmap/1
.PhoenixImportmap.importmap/1
to check for safe serialization.This change is a breaking change if you currently use
raw
to interpolate the importmap into the template.Let me know if these changes look good to you.