Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carthage] Added shared framework scheme #207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ha1f
Copy link

@ha1f ha1f commented Sep 30, 2020

closes #206

This Pull-Request contains 2 bug fixes.

1. Added shared framework scheme to build with carthage

shared scheme is required for carthage.

2. Do not embed swift standard libraries

This change was added with this commit

This will cause Assertion failed: Duplicate symbols for xxx error to build ipa of the application.
(Since libswiftCore.dylib will present under this framework and application.)

@ha1f ha1f changed the title share scheme for framework [Carthage] shared scheme for framework Sep 30, 2020
@ha1f ha1f changed the title [Carthage] shared scheme for framework [Carthage] Added shared scheme for framework Sep 30, 2020
@ha1f ha1f changed the title [Carthage] Added shared scheme for framework [Carthage] Added shared framework scheme Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Carthage] scheme for framework is not shared
1 participant