⚗️ gha seems to have problems with .net9rc1 #79
Conversation
- Cuemon.AspNetCore.Mvc.Tests - Cuemon.AspNetCore.Mvc.FunctionalTests Try to use preview7
WalkthroughThe changes involve a comprehensive update to the GitHub Actions workflow for .NET installation, transitioning from Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- src/Cuemon.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json/Cuemon.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json.csproj (1 hunks)
- src/Cuemon.Extensions.DependencyInjection/Cuemon.Extensions.DependencyInjection.csproj (1 hunks)
- src/Cuemon.Extensions.Hosting/Cuemon.Extensions.Hosting.csproj (1 hunks)
- src/Cuemon.Extensions.Net/Cuemon.Extensions.Net.csproj (1 hunks)
- src/Cuemon.Extensions.Text.Json/Cuemon.Extensions.Text.Json.csproj (1 hunks)
- src/Cuemon.Extensions.Xunit.Hosting.AspNetCore/Cuemon.Extensions.Xunit.Hosting.AspNetCore.csproj (1 hunks)
- src/Cuemon.Extensions.Xunit.Hosting/Cuemon.Extensions.Xunit.Hosting.csproj (1 hunks)
- test/Cuemon.Data.Tests/Cuemon.Data.Tests.csproj (1 hunks)
Additional comments not posted (8)
src/Cuemon.Extensions.Hosting/Cuemon.Extensions.Hosting.csproj (1)
13-13: LGTM!The change updates the version of the
Microsoft.Extensions.Hostingpackage reference for thenet9target framework from a release candidate to a preview version. This may involve new features, bug fixes, or changes in functionality that could affect how the hosting environment is utilized within the application.However, the change is isolated to the
net9target framework and is in a package reference, so it will not directly affect the code in the project. That said, it's important to review the release notes of the new package version to ensure there are no breaking changes or new features that may indirectly affect the code.Overall, the change looks good to me.
src/Cuemon.Extensions.Text.Json/Cuemon.Extensions.Text.Json.csproj (1)
20-20: Verify the reason for the change and its impact on the application.I noticed that the
System.Text.Jsonpackage version has been updated from a release candidate to a preview version for the target framework condition that starts with 'net9'. While this change may have been made to address issues or take advantage of new features in the preview version, it's important to ensure that the preview version is stable and compatible with the rest of the application.Can you please provide more context on the reason for this change and its impact on the application? Also, have you thoroughly tested the application with the preview version to ensure stability and compatibility?
src/Cuemon.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json/Cuemon.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json.csproj (1)
14-14: Verify the impact of the package version update on the application.The change looks good. However, since the package version has been updated from a release candidate to a preview version, it's important to verify that this update does not introduce any breaking changes or unexpected behavior in the application.
Run the following script to search for potential usage of the updated package:
If any usage is found, ensure that the application is thoroughly tested with the updated package to confirm that it behaves as expected.
src/Cuemon.Extensions.DependencyInjection/Cuemon.Extensions.DependencyInjection.csproj (1)
13-14: Verify the reason for downgrading the package versions.I noticed that the versions of
Microsoft.Extensions.DependencyInjectionandMicrosoft.Extensions.Options.ConfigurationExtensionshave been changed from9.0.0-rc.1.24431.7to9.0.0-preview.7.24405.7for thenet9target framework condition.This change indicates a downgrade from a release candidate version to a preview version. Preview versions are typically less stable and may have incomplete features compared to release candidates.
Can you please provide more context on why this downgrade is necessary? Are there any compatibility issues with the release candidate version that necessitate this change?
Also, please exercise caution when using preview versions, especially in a production environment. Ensure that thorough testing is done to verify that the preview versions work as expected and do not introduce any breaking changes or bugs in the project.
src/Cuemon.Extensions.Xunit.Hosting.AspNetCore/Cuemon.Extensions.Xunit.Hosting.AspNetCore.csproj (1)
19-19: Verify the impact of the package version update.The change in the version of the
Microsoft.AspNetCore.TestHostpackage from a release candidate to a preview version aligns with the PR objective of resolving issues related to the .NET 9 release candidate. However, it's important to verify that the update does not introduce any unexpected behavior or compatibility issues in the testing framework's integration with ASP.NET Core applications.Run the following script to verify the impact of the package version update:
Verification successful
No issues found with the package version update.
The update to the
Microsoft.AspNetCore.TestHostpackage version does not introduce any test failures, errors, or deprecated API usage in the relevant test directories. This suggests that the update is compatible with the current codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of the package version update on the testing framework. # Test 1: Search for test failures or errors related to the package update. rg --type cs -i $'(fail|error).*AspNetCore\.TestHost' tests/ # Test 2: Search for usage of deprecated or removed APIs from the package. rg --type cs -i $'(obsolete|deprecated).*AspNetCore\.TestHost' src/ tests/Length of output: 231
Script:
#!/bin/bash # Description: Locate test files and verify the impact of the package version update. # Locate directories or files related to tests. fd --type d --name test fd --type f --name '*.cs' --exec grep -l 'Test' {} # Adjusted verification script based on located test files. # Test 1: Search for test failures or errors related to the package update. rg --type cs -i $'(fail|error).*AspNetCore\.TestHost' <correct_test_directory> # Test 2: Search for usage of deprecated or removed APIs from the package. rg --type cs -i $'(obsolete|deprecated).*AspNetCore\.TestHost' src/ <correct_test_directory>Length of output: 804
Script:
#!/bin/bash # Description: Locate test files and verify the impact of the package version update. # Locate directories or files related to tests. fd --type d 'test' fd --type f '.cs' --exec grep -l 'Test' {} # Adjusted verification script based on located test files. # Test 1: Search for test failures or errors related to the package update. rg --type cs -i $'(fail|error).*AspNetCore\.TestHost' tests/ # Test 2: Search for usage of deprecated or removed APIs from the package. rg --type cs -i $'(obsolete|deprecated).*AspNetCore\.TestHost' src/ tests/Length of output: 23167
Script:
#!/bin/bash # Description: Verify the impact of the package version update using the correct test directories. # Test 1: Search for test failures or errors related to the package update in relevant test directories. rg --type cs -i $'(fail|error).*AspNetCore\.TestHost' test/Cuemon.Extensions.Xunit.Hosting.AspNetCore.Tests/ # Test 2: Search for usage of deprecated or removed APIs from the package in relevant directories. rg --type cs -i $'(obsolete|deprecated).*AspNetCore\.TestHost' src/ test/Cuemon.Extensions.Xunit.Hosting.AspNetCore.Tests/Length of output: 233
test/Cuemon.Data.Tests/Cuemon.Data.Tests.csproj (1)
29-29: Verify the impact of the package version change.The change is consistent with the PR objective of updating the .NET installation process within the CI pipeline to resolve issues related to the .NET 9 release candidate. However, please ensure that the shift from the release candidate version to the preview version of the
Microsoft.Data.Sqlitepackage does not introduce any breaking changes or unexpected behavior in the application.src/Cuemon.Extensions.Xunit.Hosting/Cuemon.Extensions.Xunit.Hosting.csproj (2)
14-14: Verify compatibility with the preview version.The change is consistent with the PR objective of updating the .NET installation process within the CI pipeline to use preview versions. However, please ensure that you thoroughly test the application with the
9.0.0-preview.7.24405.7version ofMicrosoft.Extensions.Hostingto identify any potential compatibility issues or breaking changes introduced by the preview version.
15-15: LGTM!
| @@ -10,7 +10,7 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup Condition="$(TargetFramework.StartsWith('net9'))"> | |||
| <PackageReference Include="Microsoft.Extensions.Http" Version="9.0.0-rc.1.24431.7" /> | |||
| <PackageReference Include="Microsoft.Extensions.Http" Version="9.0.0-preview.7.24405.7" /> | |||
There was a problem hiding this comment.
Clarify the reason for the rollback and ensure compatibility through testing.
The change in the package version from 9.0.0-rc.1.24431.7 to 9.0.0-preview.7.24405.7 appears to be a rollback from a release candidate to a preview version. Preview versions are typically less stable than release candidates and may introduce breaking changes.
Please provide clarification on the reason for this rollback. Additionally, ensure that the preview version is compatible with the rest of the application and its dependencies by conducting thorough testing to identify any potential issues.
|
Silently fixed by Microsoft .. without details: dotnet/sdk#43432 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 80.21% 80.21%
=======================================
Files 708 708
Lines 21638 21638
Branches 2180 2180
=======================================
Hits 17357 17357
Misses 4228 4228
Partials 53 53 ☔ View full report in Codecov by Sentry. |
PR Classification
Update to .NET installation process in CI pipeline.
PR Summary
Updated the .NET installation step to use a newer action and specified versions.
.github/workflows/ci.yml: Replacedcodebeltnet/install-dotnet@v1withactions/setup-dotnet@v4..github/workflows/ci.yml: Added installation of .NET versions6.0.x,8.0.x, and conditional preview version9.0.100-preview.7.24407.12..github/workflows/ci.yml: Setdotnet-qualityparameter topreviewfor the preview version.Problem discovered for:
Summary by CodeRabbit
New Features
Bug Fixes