Introduce MatchSupportedRequestFn
option for more granular decision making process to compress a response
#57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
WithMatchSupportedRequestFn
option is introduced. This allows to make a decision about response compression basing on a combination of other headers and values from a request (like #42).Changes
WithMatchSupportedRequestFn()
accepts a function with a signature:func(req *http.Request) (ok bool, supported bool)
. The first returnedok
value is a marker that no other checks if a compression is excluded should be applied:supported
is a decision for compression.MatchSupportedRequestFn
has a precedence overExcluded{Extensions,Paths,PathesRegexs}
lists. Ifok
isfalse
, the other (= the mentioned before) exclusion rules are applied.Notes
http.Request
is used intentionally instead of, say,gin.Context
. The goal is to have a safe limited interface.