Support template delimiters #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch-coders
approved these changes
Nov 23, 2022
|
@parnic I need this feature for support custom delimiters and avoid trouble with other js libraries :) |
Have at it. |
|
Hope to merge into the master branch earlier. ^_^ |
# Conflicts: # dynamic.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for custom delimiters in multitemplate. It only works currently for AddFromStrings and AddFromFiles, primarily because it's easy for anyone to simply use .Delims() themselves on the returned template if it's not a template made up of other templates. But if there is desire to make this broader-reaching, I could update it.
Note that my preferred way of doing this would have been to add the options to, for example, NewRenderer(), but since Renderer and DynamicRenderer are just type aliases for maps, that would have broken existing code since anyone relying on those types to still be maps would be out of luck (especially since this project doesn't use go module versioning).
I also have not yet updated the examples, readme, tests, etc. with this new feature. If this PR is desired, I can do all that work, but for now this gave me what I needed for my project to use custom delimiters with multitemplate.
Fixes #24