Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remplacer l'envoi d'opportunités de mailjet vers brevo #1652

Closed
wants to merge 2 commits into from
Closed

fix: remplacer l'envoi d'opportunités de mailjet vers brevo #1652

wants to merge 2 commits into from

Conversation

madjid-asa
Copy link
Contributor

@madjid-asa madjid-asa commented Feb 4, 2025 •
edited
Loading

Quoi ?

Remplacement du mail d'envoi des opportunités commerciales de mailjet vers Brevo.

Pourquoi ?

Un oubli durant la migration.

Todo

  • Créer la migration pour le transactionalEmail

@madjid-asa madjid-asa self-assigned this Feb 4, 2025
@madjid-asa madjid-asa force-pushed the madjid-asa/update-email-tender-partner branch from 10ffa64 to dc14989 Compare February 4, 2025 19:42
@madjid-asa madjid-asa mentioned this pull request Feb 4, 2025
Merged
@madjid-asa madjid-asa force-pushed the madjid-asa/update-email-tender-partner branch from dc14989 to 3b8e5c7 Compare February 4, 2025 21:25
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 4, 2025
View reviewed changes
lemarche/static/js/favorite_item.js Dismissed Show dismissed Hide dismissed
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 4, 2025
View reviewed changes
lemarche/siaes/management/commands/import_esat_from_asp.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_from_asp.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_from_csv.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_gesat.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_handeco.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_sep.py Dismissed Show dismissed Hide dismissed
lemarche/www/auth/views.py Dismissed Show dismissed Hide dismissed
lemarche/www/siaes/views.py Dismissed Show dismissed Hide dismissed
lemarche/www/siaes/views.py Dismissed Show dismissed Hide dismissed
@madjid-asa madjid-asa force-pushed the madjid-asa/update-email-tender-partner branch from 3b8e5c7 to 096b372 Compare February 5, 2025 10:04
SebastienReuiller
SebastienReuiller approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@SebastienReuiller SebastienReuiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!
Le template existe déjà dans l'admin en prod et côté Brevo 👍🏽, donc la migration que tu mentionnes ne semble pas nécessaire.

@Guilouf
Copy link
Collaborator

Guilouf commented Feb 7, 2025

Le patch était déjà présent ici https://github.com/gip-inclusion/le-marche/pull/1653/files#diff-e2905ba69a686887175c7fce051bf9620e9dd0faea4767fd6c80f2af680f2ade qui a été mergé ici #1632 donc je ferme cette PR pour ne pas compliquer la situation.

@Guilouf Guilouf closed this Feb 7, 2025
@madjid-asa madjid-asa deleted the madjid-asa/update-email-tender-partner branch February 12, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastienReuiller SebastienReuiller SebastienReuiller approved these changes

@chloend chloend Awaiting requested review from chloend

@Guilouf Guilouf Awaiting requested review from Guilouf

Assignees

@madjid-asa madjid-asa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madjid-asa @Guilouf @SebastienReuiller