[Mon recap] Modification de la source du barometre de mon recap + ajout du département sur toutes les tables #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickPassa
force-pushed
the
YannickPassa/sources_monrecap
branch
2 times, most recently
from
25bbc7e to
31f2a95
Compare
tests drop cascade
removing a bad dptmt view
YannickPassa
force-pushed
the
YannickPassa/sources_monrecap
branch
from
31f2a95 to
f705858
Compare
laurinehu
approved these changes
Dec 18, 2024
| drop table if exists monrecap.barometre cascade;""" | ||
| ) | ||
|
|
||
| tables = ["Commandes", "Contacts", "Baromètre - Airflow"] | ||
| table_mapping = {"Commandes": "Commandes_v0", "Contacts": "Contacts_v0"} | ||
| tables = ["Commandes", "Contacts"] | ||
| for table_name in tables: |
There was a problem hiding this comment.
tu pourrais enlever ligne 32 et faire for table_name in tables.keys()
(bonne pratique pr pas avoir besoin de changer deux lignes si tu traites plus de tables demain)
| @@ -37,15 +39,22 @@ def monrecap_airtable(**kwargs): | |||
| df["Nom Departement"] = df["Code Postal"].apply( | |||
| lambda cp: "-".join([item for item in departments.get_department(cp) if item is not None]) | |||
| ) | |||
| if table_name == "Contacts": | |||
| elif table_name == "Contacts": | |||
| # fixing Annaelle's double quotes, if you read this I'll get my revenge | |||
There was a problem hiding this comment.
attends je bug ton if devient un elif ? il manque un if avant non ?
There was a problem hiding this comment.
JAI RIEN DIT - j'ai oublié de cliquer sur un bouton
laurinehu
approved these changes
Dec 18, 2024
| @@ -37,15 +39,22 @@ def monrecap_airtable(**kwargs): | |||
| df["Nom Departement"] = df["Code Postal"].apply( | |||
| lambda cp: "-".join([item for item in departments.get_department(cp) if item is not None]) | |||
| ) | |||
| if table_name == "Contacts": | |||
| elif table_name == "Contacts": | |||
| # fixing Annaelle's double quotes, if you read this I'll get my revenge | |||
There was a problem hiding this comment.
JAI RIEN DIT - j'ai oublié de cliquer sur un bouton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Carte Notion : **
Pourquoi ?
Checks