Start adding types using monkeytype. #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to drop support for older pythons for this to be useful. After running `tox -e monkeytype-py311`, you can then list which modules have type data via `build/tox/monkeytype-py311/bin/monkeytype list-modules` and apply the type annotations to a specific modules with `build/tox/monkeytype-py311/bin/monkeytype apply <module>`. Check types using `tox -e type`. The next steps are to turn on a few more mypy warnings, then start adding types to more of the source files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to drop support for older pythons for this to be useful.
After running
tox -e monkeytype-py311, you can then list which modules have type data viabuild/tox/monkeytype-py311/bin/monkeytype list-modulesand apply the type annotations to a specific modules withbuild/tox/monkeytype-py311/bin/monkeytype apply <module>.Check types using
tox -e type.The next steps are to turn on a few more mypy warnings, then start adding types to more of the source files.