Infer DICOM file size, when possible #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google Healthcare API supports single-part requests for DICOM files. Single-part requests are not officially supported by the DICOMweb standard, but they are easier to work with. Google Healthcare API also provides the Content-Length. We can utilize this information to infer the DICOM file size without having to stream the whole file. This PR adds logic to automatically infer the DICOM file size and set it, when possible, without streaming the whole file. Unfortunately, dcm4chee does not support single-part requests, and they do not return a Content-Length either. So we must still stream the whole file to get the file size for dcm4chee servers. But if we determine a new way to infer the file size, we can add it as well. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
dicomweb-infer-file-size
branch
from
721d6a2 to
c981c54
Compare
manthey
approved these changes
Jan 31, 2024
|
In a follow-up PR, I will store whether the server supports singlepart requests in the assetstore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Healthcare API supports single-part requests for DICOM files. Single-part requests are not officially supported by the DICOMweb standard, but they are easier to work with. Google Healthcare API also provides the Content-Length. We can utilize this information to infer the DICOM file size without having to stream the whole file.
This PR adds logic to automatically infer the DICOM file size and set it, when possible, without streaming the whole file.
Unfortunately, dcm4chee does not support single-part requests, and they do not return a Content-Length either. So we must still stream the whole file to get the file size for dcm4chee servers. But if we determine a new way to infer the file size, we can add it as well.
To do: