Reduce bioformats keeping file handles open #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bioformats tries to open a zip file, it opens the file once per internal file. If it fails to find a file that can be opened within the zip, it throws an error and leaves all of the file handles open. By dividing the reader into more steps, we can ask to open an empty file, which somehow releases the file handles.
manthey
force-pushed
the
bioformats-handle-release
branch
from
feb9a9f to
15b938e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bioformats tries to open a zip file, it opens the file once per internal file. If it fails to find a file that can be opened within the zip, it throws an error and leaves all of the file handles open. By dividing the reader into more steps, we can ask to open an empty file, which somehow releases the file handles. This happens with non-zip files, though it is less problematic.