Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipyleaflet 0.19 fixes an issue with inverting bounds coordinates #1775

Merged
merged 1 commit into from
Jan 16, 2025
Merged

ipyleaflet 0.19 fixes an issue with inverting bounds coordinates #1775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
### Bug Fixes

- Fix scaling tiles from stripped tiffs in some instances ([#1773](../../pull/1773))
- Updated jupyter support for ipyleaflet ([#1775](../../pull/1775))

## 1.30.6

Expand Down
12 changes: 1 addition & 11 deletions large_image/tilesource/jupyter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,21 +276,11 @@ def make_map(
crs = dict(
name='PixelSpace',
custom=True,
# Why does this need to be 256?
resolutions=[2 ** (metadata['levels'] - 1 - l) for l in range(20)],

# This works but has x and y reversed
proj4def='+proj=longlat +axis=esu',
bounds=[[0, 0], [metadata['sizeY'], metadata['sizeX']]],
# Why is origin X, Y but bounds Y, X?
bounds=[[0, 0], [metadata['sizeX'], metadata['sizeY']]],
origin=[0, metadata['sizeY']],

# This almost works to fix the x, y reversal, but
# - bounds are weird and other issues occur
# proj4def='+proj=longlat +axis=seu',
# bounds=[[-metadata['sizeX'],-metadata['sizeY']],
# [metadata['sizeX'],metadata['sizeY']]],
# origin=[0,0],
)
layer = layer or self._layer

Expand Down
Loading