Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build plugin client code on release #1777

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

naglepuff
Copy link
Collaborator

Ship Girder plugin packages with built client packages.

This makes it easier for dependent plugins to use large_image Girder plugins.

@naglepuff naglepuff requested a review from manthey January 17, 2025 18:23
@naglepuff naglepuff force-pushed the girder-5-build-client-on-release branch from 6343129 to eae3afd Compare January 20, 2025 22:35
@naglepuff naglepuff force-pushed the girder-5-build-client-on-release branch from eae3afd to ec069cb Compare January 21, 2025 16:38
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@naglepuff
Copy link
Collaborator Author

@manthey I had to add MANIFEST.in files for girder_large_image and girder_large_image_annotation. Locally this seems to have the intended effect of including built client artifacts in the python distribution. This is what girder plugins in the main girder repo do, so I copied that behavior here.

@naglepuff naglepuff requested a review from manthey January 22, 2025 19:27
This is necessary because we want to build the client packages for
girder plugins whose source code is contained within this repository.
@manthey
Copy link
Member

manthey commented Jan 23, 2025

As a follow on (see #1786): we also have a make_wheels.sh script that currently runs as CI and pushes wheels as artifacts. We should get rid of that and instead push the wheels we make in the check_release as artifacts. We should also adjust the release script to push all wheels to twine in one command rather than each in turn, so if the actual twine command fails, it fails for all components.

@naglepuff naglepuff merged commit d9391e7 into girder-5 Jan 23, 2025
18 checks passed
@naglepuff naglepuff deleted the girder-5-build-client-on-release branch January 23, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants