-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build plugin client code on release #1777
Conversation
6343129
to
eae3afd
Compare
eae3afd
to
ec069cb
Compare
@manthey I had to add |
This is necessary because we want to build the client packages for girder plugins whose source code is contained within this repository.
As a follow on (see #1786): we also have a make_wheels.sh script that currently runs as CI and pushes wheels as artifacts. We should get rid of that and instead push the wheels we make in the check_release as artifacts. We should also adjust the release script to push all wheels to twine in one command rather than each in turn, so if the actual twine command fails, it fails for all components. |
Ship Girder plugin packages with built client packages.
This makes it easier for dependent plugins to use
large_image
Girder plugins.