Limit ASGI_THREADS value in Heroku #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value is far too high and quickly exhausts postgres's default connection pool limit of 20 in Heroku.
|
We might also consider using a connection pooler instead of limiting the number of python threads. There is a pgBouncer heroku buildpack. One tradeoff is that pgbouncer requires another dyno. There may be other issues as well that I'm not aware of, but I wanted to at least bring this up. Most of this info I got from the article linked in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value is far too high and quickly exhausts postgres's default connection pool limit of 20 in Heroku.
This is related to the same cluster of Resonant PRs as #81