Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made navbar and footer for the website #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

musk101
Copy link
Contributor

@musk101 musk101 commented Mar 31, 2021

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.

Closes #35

Node modules added in Git Ignore and required changes made

Please delete options that are not relevant.

I have added the navbar
I have added the footer

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Screenshots

Original Updated
original screenshot updated screenshot

@musk101 musk101 mentioned this pull request Mar 31, 2021
7 tasks
@musk101
Copy link
Contributor Author

musk101 commented Apr 1, 2021

@codewithvk can you please review my PR that solves issues #35 and #75 .

@codewithvk
Copy link
Collaborator

@musk101 could you please attach a screenshot?

@musk101
Copy link
Contributor Author

musk101 commented Apr 2, 2021

Yes sure @codewithvk

navbar:
image

Footer:
image

@musk101
Copy link
Contributor Author

musk101 commented Apr 3, 2021

@codewithvk can you please review my PR so that I can work on further issues.

@codewithvk
Copy link
Collaborator

Hey @musk101 , Apologies for my mistake, I had created 2 issues regarding the Navbar and Footer so that Fotter has been already added and navbar PR made. It would be great if you work on some other issue or you can more styled on Navbar and footer :)

Hope you understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Navbar
2 participants