-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve worktree .git files to repository .git directory #642
Resolve worktree .git files to repository .git directory #642
Conversation
Thanks for the investigation @jkylling ! Not the most elegant fix, but practical and does seem to solve the issue |
Do you have better suggestions @xkrogen? |
I took a quick read through the Details section for git-worktree and the worktree-related stuff in gitrepository-layout. It seems like this should work if we assume the There is also the potential situation where |
76a827b
to
b1d8440
Compare
@TheSnoozer I've gone through the contributor checklist and fixed the check style violations. Do you think we should merge this? |
Thanks again for your contribution! Merged now. |
Hey @TheSnoozer just curious when you expect this to go into a release? I'm not familiar with the release lifecycle of this project, just wondering when I'll be able to adopt it downstream. Big thanks to both of you btw :) |
The release cycle is to wait until someone mentions they want a release ;-) Will do that as soon as I have time (sorry this project is still only my free time) :-) |
Released now as 7.0.0 via #623. |
Heh awesome ... Thanks so much @TheSnoozer ! |
Context
Fix #639
I have not tested this change end to end.
Contributor Checklist
mvn clean package
checkstyle
coding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B