ci: run Git's entire test suite #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
force-pushed
the
run-gits-test-suite
branch
2 times, most recently
from
ad01166 to
725b84b
Compare
One particularly important part of Git for Windows' MSYS2 runtime is that it is used to run Git's tests, and regressions happened there: For example, the first iteration of MSYS2 runtime v3.5.5 caused plenty of hangs. This was realized unfortunately only after deploying the msys2-runtime Pacman package, and some painful vacation-time scrambling was required to revert to v3.5.4.This was realized unfortunately only after deploying the msys2-runtime Pacman package, and some painful vacation-time scrambling was required to revert to v3.5.4. To verify that this does not happen anymore, let's reuse what `setup-git-for-windows-sdk` uses in Git's very own CI: - determine the latest successful `ci-artifacts` workflow run in git-for-windows/git-sdk-64 - download its Git files and build artifacts - download its minimal-sdk - overwrite the MSYS2 runtime in the minimal-sdk - run the test suite and the assorted validations just like the `ci-artifacts` workflow (from which these jobs are copied) This obviously adds a hefty time penalty (around 7 minutes!) to every MSYS2 runtime PR in the git-for-windows org. Happily, these days we don't need many of those, and the balance between things like the v3.5.5 scramble and waiting a little longer for the CI to finish is clearly in favor of the latter. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
run-gits-test-suite
branch
from
3d65449 to
929a93e
Compare
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 26, 2025
ci: run Git's entire test suite
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 26, 2025
ci: run Git's entire test suite
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 26, 2025
ci: run Git's entire test suite
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 27, 2025
ci: run Git's entire test suite
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 28, 2025
ci: run Git's entire test suite
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 30, 2025
ci: run Git's entire test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One particularly important part of Git for Windows' MSYS2 runtime is that it is used to run Git's tests, and regressions happened there: For example, the first iteration of MSYS2 runtime v3.5.5 caused plenty of hangs. This was realized unfortunately only after deploying the
msys2-runtimePacman package, and some painful vacation-time scrambling was required to revert to v3.5.4.To verify that this does not happen anymore, let's reuse what
setup-git-for-windows-sdkuses in Git's very own CI:ci-artifactsworkflow run in git-for-windows/git-sdk-64ci-artifactsworkflow (from which these jobs are copied)This obviously adds a hefty time penalty to every MSYS2 runtime PR in the
git-for-windowsorg. Happily, these days we don't need many of those, and the balance between things like the v3.5.5 scramble and waiting a little longer for the CI to finish is clearly in favor of the latter.