Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eslint monorepo svelte 5 setup #5246

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

fix: eslint monorepo svelte 5 setup #5246

wants to merge 12 commits into from
+484 −330

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Oct 21, 2024 •
edited
Loading

☕️ Reasoning

  • Fix eslint issue where first character of .svelte files was throwing errors where spreading of props was taking place.
  • In addition, we weren't checking a few eslint rules previously, which we are now. i.e. @typescript-eslint/no-unused-expression
  • Enable helpful monorepo tsconfig rules for child packages

🧢 Changes

@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitbutler-web ⬜️ Skipped (Inspect) Oct 21, 2024 4:26pm

@ndom91 ndom91 mentioned this pull request Oct 21, 2024
Closed
@ndom91 ndom91 mentioned this pull request Oct 21, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlvi krlvi krlvi approved these changes

Assignees
No one assigned
Labels
@gitbutler/desktop @gitbutler/ui @gitbutler/web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndom91 @krlvi