Integrate new hunk dependency algorithm

[mtsgrd]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
gitbutler-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 2:28pm

[krlvi]

You can use the do different kinds of subtraction as a method on the new_lines, and you wont have to cast.
You probably wanna do the 'checked' kind though, which returns an Option.

Seems like net_lines is called from add_new which is called from add, which returns a Result.
So you can do something like

        self.net_lines()
            .checked_sub_unsigned(self.old_lines)
            .ok_or(anyhow!("Overflowed computing net lines"))

and do the ? operator. It's gonna be so much easier to debug in the future

[krlvi]

You can skip from_iter and have the compiler infer the type like this

paths: paths
                .iter()
                .map(|path| (path.clone(), combine_path_ranges(path, &stacks)))
                .collect(),
                ```

[krlvi]

Kinda related to our IRL conversation earlier... so there is this convention to no "stutter" in names - this is module workspace, name WorkspaceRanges.
So if you want your API to be consumed as a hierarchy, it would be idiomatic to have workspace::Ranges at the consumption side.
I tend to prefer a flatter structure - exporting these types in the root level, and in that case I need the name would be WorkspaceRanges to be descriptive.
This is doing both which is suboptimal. Can rename later but trying to help shape the thinking here a bit

[krlvi]

You can write these like .flat_map(StackRanges::unique_paths) as well

[krlvi]

There is still quite a bit of panic-y access by index. You can see it by adding this clippy rule at the top of the file

#![warn(clippy::indexing_slicing)]

While annoying to replace now, it will pay dividends if/when we hit stuff to debug