fix: fix collections not being fetched

gitcoinco · Dec 18, 2023 · ce97398 · ce97398
1 parent dd04719
commit ce97398
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/packages/grant-explorer/src/features/categories/hooks/useCategories.ts b/packages/grant-explorer/src/features/categories/hooks/useCategories.ts
@@ -17,15 +17,18 @@ export const useCategory = (
 ): SWRResponse<SearchBasedProjectCategory | undefined> => {
   const dataLayer = useDataLayer();
 
-  return useSWR(["categories"], async () => {
+  return useSWR(id === null ? null : ["categories"], async () => {
     if (id === null) {
-      return undefined;
-    } else {
-      const { category } = await dataLayer.query({
-        type: "search-based-project-category",
-        id,
-      });
-      return category === null ? undefined : category;
+      // The first argument to useSRW will ensure that this function never gets
+      // called if options is `null`. If it's still called, we fail early and
+      // clearly.
+      throw new Error("Bug");
     }
+
+    const { category } = await dataLayer.query({
+      type: "search-based-project-category",
+      id,
+    });
+    return category === null ? undefined : category;
   });
 };
diff --git a/packages/grant-explorer/src/features/collections/hooks/useCollections.ts b/packages/grant-explorer/src/features/collections/hooks/useCollections.ts
@@ -30,7 +30,6 @@ export const useCollection = (
       id,
     });
 
-    // TODObard return null instead of undefined if not found
     return collection === null ? undefined : collection;
   });
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -30,7 +30,6 @@ export const useCollection = ( @@
           id,
         });
-        // TODObard return null instead of undefined if not found
         return collection === null ? undefined : collection;
       });
     };