Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Passport text in cart for rounds not using Passport #2781

Closed
meglister opened this issue Jan 8, 2024 · 0 comments · Fixed by #2795
Closed

Remove Passport text in cart for rounds not using Passport #2781

meglister opened this issue Jan 8, 2024 · 0 comments · Fixed by #2795
Assignees
Labels
bug Something isn't working

Comments

@meglister
Copy link
Member

meglister commented Jan 8, 2024

What was the URL where the error occurred?

https://explorer.gitcoin.co/#/cart

What happened?

I am seeing a prompt to use Passport even though this round has disabled Passport. This occurs in TWO places:

  • help text for estimated match
  • modal triggered by pressing "Submit your donation" (screenshot here:
    image010824 )

What should have happened instead?

For help text:

  • New default text: Keep in mind that this is a potential match that may change with the number of donations to a round.
  • "Estimated match" text should appear in green regardless of the passport status when a round is not using Passport

For modal:

  • do not trigger modal if no rounds in cart are using Passport

Steps to Reproduce

  1. Go to a round not using passport: https://explorer.gitcoin.co/#/round/137/0x08C7516e91C19D37E8638F58991fbb036c3C3E04
  2. Add project to cart
  3. Observe issue

What browser(s) are you seeing the problem on?

No response

What chain(s) did the error occur on?

Polygon

Relevant log output

No response

@meglister meglister added the bug Something isn't working label Jan 8, 2024
@meglister meglister assigned jesuloluwao and unassigned jesuloluwao Jan 8, 2024
@meglister meglister moved this to Bugs & Chores in Grants Lab Jan 8, 2024
@vacekj vacekj self-assigned this Jan 8, 2024
@vacekj vacekj moved this from Bugs & Chores to In Progress in Grants Lab Jan 8, 2024
@vacekj vacekj moved this from In Progress to PR Review in Grants Lab Jan 9, 2024
@vacekj vacekj linked a pull request Jan 9, 2024 that will close this issue
5 tasks
@github-project-automation github-project-automation bot moved this from PR Review to Live in Grants Lab Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants