Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if no passport rounds in cart, act as if passport is valid #2795

Merged

Conversation

vacekj
Copy link
Contributor

@vacekj vacekj commented Jan 9, 2024

Fixes: #2781

Description

if no passport-protected rounds are in cart, act as if passport is valid in matching estimates, and don't display the passport invalid banner.

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@vacekj vacekj requested review from a team as code owners January 9, 2024 10:16
@vacekj vacekj linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 0:13am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 0:13am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 0:13am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 0:13am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 0:13am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 0:13am

Copy link

gitstream-cm bot commented Jan 9, 2024

🥷 Code experts: bhargavaparoksham

vacekj, bhargavaparoksham have most 👩‍💻 activity in the files.
bhargavaparoksham, vacekj have most 🧠 knowledge in the files.

See details

packages/grant-explorer/src/features/common/MatchingEstimateTooltip.tsx

Activity based on git-commit:

vacekj bhargavaparoksham
JAN
DEC
NOV
OCT 57 additions & 0 deletions 1 additions & 1 deletions
SEP
AUG

Knowledge based on git-blame:
vacekj: 98%
bhargavaparoksham: 2%

packages/grant-explorer/src/features/round/ViewCartPage/SummaryContainer.tsx

Activity based on git-commit:

vacekj bhargavaparoksham
JAN
DEC 144 additions & 87 deletions
NOV 4 additions & 2 deletions
OCT 91 additions & 15 deletions 5 additions & 11 deletions
SEP 13 additions & 7 deletions
AUG 11 additions & 16 deletions 368 additions & 0 deletions

Knowledge based on git-blame:
bhargavaparoksham: 51%
vacekj: 39%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Jan 9, 2024

This PR is 65% new code.

Copy link
Member

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vacekj vacekj merged commit e5a5111 into main Jan 10, 2024
19 checks passed
@vacekj vacekj deleted the 2781-remove-passport-text-in-cart-for-rounds-not-using-passport branch January 10, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Passport text in cart for rounds not using Passport
3 participants