Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-enable matching estimates for polygon #2658

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

vacekj
Copy link
Contributor

@vacekj vacekj commented Nov 21, 2023

PR checklist

For every PR, make sure that these statements are true:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't contain type casts and non-null assertions.
  • Doesn't add @ts-ignore.
  • Doesn't disable lints.
  • Doesn't use useState just for computation - use plain variables instead.
  • Splits components into pure components that don't depend on external state or hooks.
  • Avoid embedding components within other components
  • Doesn't propagate optional values without good reason, doesn't mark property values as optional if that doesn't represent reality.
  • Doesn't duplicate existing code.
  • Parses out-of-domain data - this includes user input, API respones, on-chain data etc.
  • Doesn't contain commented out code.
  • Doesn't contain skipped or empty tests.
  • If this PR adds/updates any feature, it adds/updates its test script

Subjective - at the discretion of the reviewers

  • Does things as simply as possible, but not simpler.
  • Doesn't reinvent the wheel or create premature abstractions.
Description
Refers/Fixes

fixes #2657

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 11:00am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 11:00am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 11:00am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 11:00am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 11:00am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 11:00am

Copy link

gitstream-cm bot commented Nov 21, 2023

🥷 Code experts: no user but you matched threshold 10

vacekj has most 👩‍💻 activity in the files.
vacekj, bhargavaparoksham have most 🧠 knowledge in the files.

See details

packages/grant-explorer/src/features/round/ViewCartPage/RoundInCart.tsx

Activity based on git-commit:

vacekj
NOV 7 additions & 1 deletions
OCT 114 additions & 25 deletions
SEP 2 additions & 2 deletions
AUG
JUL
JUN

Knowledge based on git-blame:
vacekj: 79%
bhargavaparoksham: 21%

packages/grant-explorer/src/hooks/matchingEstimate.ts

Activity based on git-commit:

vacekj
NOV 9 additions & 1 deletions
OCT 87 additions & 0 deletions
SEP
AUG
JUL
JUN

Knowledge based on git-blame:
vacekj: 98%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Nov 21, 2023

This PR is 11.11111111111111% new code.

@melissa-neira
Copy link
Member

@vacekj I'm seeing this - not sure if this is the expected behavior
Screenshot 2023-11-21 at 12 32 38

Copy link
Contributor

@bhargavaparoksham bhargavaparoksham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @vacekj fyi the matching estimates was visible only on staging & not it was not on explorer prod preview. Please check once.

Copy link
Member

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vacekj vacekj merged commit 0245c75 into main Nov 21, 2023
13 checks passed
@vacekj vacekj deleted the 2657-re-enable-polygon-matching-estimates branch November 21, 2023 15:13
andremury pushed a commit to show-karma/grants-stack that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable polygon matching estimates
3 participants