Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pins to a working fork of goslate (dep on django-autotranslate) #9687

Closed
wants to merge 1 commit into from

Conversation

gdixon
Copy link
Contributor

@gdixon gdixon commented Nov 15, 2021

Description

This PR will pin us to a fork of goslate in order to fix our CI build (as well as our local install) following recent changes in setuptools (see here for details: pypa/setuptools#1390)

--

I have opened a PR against goslate (zhuoqiang/goslate#2) which will solve this without the need for us to pin anything however it will also require a version bump on django-autotranslate so we should merge this and look to the maintainers of these external libs to roll out a fix.

Refers/Fixes

Failing build on travis (and my local)

Screenshot 2021-11-15 at 21 50 23

Testing

Tested locally

Copy link
Contributor

@chibie chibie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm... your goslate pr has been merged tho 💯

@gdixon
Copy link
Contributor Author

gdixon commented Nov 16, 2021

Closing this out, @zhuoqiang has merged and published my PR - zhuoqiang/goslate#2 (comment) and there are no versions pinned in django_autotranslate (https://github.com/ankitpopli1891/django-autotranslate/blob/master/requirements.txt) so this PR is surplus to requirement 🚀

I think we could also drop django_autotranslate as it doesn't seem to be working - @thelostone-mc - do you know when this was last used?

@gdixon gdixon closed this Nov 16, 2021
@thelostone-mc
Copy link
Member

This can be retried as it's not been used for a while from what I'm aware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants