Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension support for MusicXML (.mxl). Addresses issue #3641. #3651

Closed
wants to merge 4 commits into from

Conversation

nolanholden
Copy link

@nolanholden nolanholden commented May 27, 2017

The changes are:

  1. add entry in languages.yml for MXL
  2. add samples to samples/MXL/

Here is some in-the-wild usage:
https://github.com/search?p=3&q=extension%3Amxl+www.musicxml.org&type=Code&utf8=%E2%9C%93

(Addresses issue #3641.)

@pchaigno
Copy link
Contributor

I couldn't find many MusicXML files in-the-wild. Most .mxl files appear to be ZIP archives.

@nolanholden
Copy link
Author

Hello, @pchaigno .
Updated above are plenty of in-the-wild MusicXML (.mxl) documents.
Please review when you have a chance.

Thank you!
-Nolan

@lildude
Copy link
Member

lildude commented Jun 30, 2017

Updated above are plenty of in-the-wild MusicXML (.mxl) documents.

I'm afraid I disagree. 30 between 6 users (from your own search query) isn't sufficiently popular at this time.

@pchaigno
Copy link
Contributor

pchaigno commented Aug 4, 2018

Closing in favor of #4219. We'll monitor the popularity of the extension there.

If you have an improved search query compared to the one used in #4219, please post it here and I'll update #4219.

@pchaigno pchaigno closed this Aug 4, 2018
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants