-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PureBasic: Add ".pbf" and ".pbp" Extensions #3926
Conversation
Add PureBasic's `.pbf` and `.pbp` file extensions: - `.pbf` to "PureBasic" setcion - `.pbp` to "XML" setcion `*.pbf` files are "form files" created with PureBasic IDE's integrated Form Designer. Form files' contents are just PureBasic sourcecode: http://www.purebasic.com/documentation/reference/ide_form.html `*.pbp` files are PureBasic project files, created by the PureBasic IDE. They are just XML files: http://www.purebasic.com/documentation/reference/ide_projects.html http://www.purebasic.com/documentation/reference/ide_tools.html
Please have a look at the guidelines to add support for a new extension to Linguist. In particular, you'll need to link to a GitHub search result page showing in-the-wild usage, for each extension. |
This example provides samples of a project file (`*.pbp`) and a form file (`*.pbf`)
Ok, I've created an example project in " I'm not sure about the search results links requirement, the guidelines are quite terse about it. The best I've managed is this: ... but search result include some false positives for |
First off, thanks for the contribution. I've taken a quick look at the general structure of I performed a similar search for As per our contributing guidelines, we really need each extension individually to be used in hundreds of repositories. Neither extension meets this requirement. Accordingly, we can't accept this PR at this stage and I've labeled this PR accordingly. Additionally, the failures in this PR are legit failures that need to be addressed. The two |
I understand your point, but as far as the Conventions aside, they are just plain PureBasic syntax files, using the same syntax. PureBasic is a bit of a niche language, add to that that the I'd like though to make a point of the fact that PureBasic is a 20 years old language (started out in 1998, and underwent major updates). It originally run on Amiga (the Amiga version being open source now), and currently runs on Windows, Linux and macOS. Maybe the sheer fact that it has been around for 20 years could be taken into account in this case. https://en.wikipedia.org/wiki/PureBasic As said, I'm only trying to register on Linguist variations of what is an already present extension — I've provided links to the official documentation in support of that.
Correct; I just added them for the sake of completness — basically, I've put in this PR all the manual settings that I usually put in the |
They may be, but we require all extensions meet these requirements, regardless of how popular the language or another extension of that language is. |
I understand. What should we do then, should I close the pull request? Can I then safely delete my PR branch and/or my fork of Linguist? |
It's entirely up to you. You can keep the PR open and check up on the popularity over time, but then you can't delete your fork. Or close the PR, delete your fork and keep an eye on the popularity and when things become more popular open a new PR. |
Thanks for the tips!
I'll do that, in the last 2 years members of PureBasic's community have started moving their projects on GitHub, and their number is growing. Hopefully, the pending target might be reached in the course of time. (I'm personally involved in helping a project that is trying to gather on GitHub all the loose projects that have been scattered on various websites in the years, and asking authors on the PB Forums to join efforts with us and try to create a centralized and collaborative archive). |
Add PureBasic's
.pbf
and.pbp
file extensions:.pbf
to "PureBasic" setcion.pbp
to "XML" setcion*.pbf
files are "form files" created with PureBasic IDE's integrated Form Designer. Form files' contents are just PureBasic sourcecode:http://www.purebasic.com/documentation/reference/ide_form.html
*.pbp
files are PureBasic project files, created by the PureBasic IDE. They are just XML files:http://www.purebasic.com/documentation/reference/ide_projects.html
http://www.purebasic.com/documentation/reference/ide_tools.html