Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change text direction in GUIDE_ar.md to RTL #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhalsubhi
Copy link

The Arabic language is "RTL(Right-to-left)" language, so I change the direction of GUIDE_ar.md file to RTL by contain each element inside div with dir="rtl" attribute

@j-f1
Copy link

j-f1 commented Oct 2, 2020

I’m pretty sure browsers will automatically interpret Arabic text as right-to-left, even without an explicit dir=rtl attribute.

@mhalsubhi
Copy link
Author

According to my understanding actually, it's not because the default value of dir attribute is ltr even if the browser's language is set to Arabic, the browser will set the correct direction automatically if the default value of dir is auto see this example

also, the issue it is becoming very hard to read when mixing Arabic and English here's how we read it before fix
image

the blue arrows (number 3) it's difficult and uncomfortable to read

here's how we read it after fix
image
this is the comfortable and correct way we read Arabic mixed with English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants