-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actions analysis to code scanning #2725
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
09c5825
to
80fe55a
Compare
80fe55a
to
7a4427f
Compare
I'm actually a little confused by this workflow file but I think we actually need to add the matrixed language variable in the 2nd
codeql-action/.github/workflows/codeql.yml Line 102 in e7c0c9d
We can see that currently the I'm not sure we care about the languages specified in |
Hmmm...I think you're right. I was just being lazy, making changes, and hoping it would work out. I should be thinking deeper about this. It might just be easier to create a separate job for the actions run. I don't think we need to matrix it over multiple OSes. |
Create a new job to run actions since we don't need to matrix the runs across multiple OSes.
7a4427f
to
de4457e
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Seems like it worked! |
|
||
|
||
analyze-actions: | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want this job to depend on check-codeql-versions
? I guess it's not necessary, as long as one of them depends on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that we don't need it.
This workflow is matrixed on multiple versions of CodeQL mainly as an integration test. Since we're using the different versions for analyzing JavaScript, I was thinking that we don't need to do the same for actios. Though, if you can think of a reason, we can change this.
I changed the name of the job from |
This enables the new actions analysis queries for this repository.
Merge / deployment checklist