Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: mc <[email protected]>
Co-authored-by: Simon Friis Vindum <[email protected]>
  • Loading branch information
3 people authored Jan 24, 2025
1 parent 4b28843 commit ed5f19b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions rust/ql/src/queries/security/CWE-312/CleartextLogging.qhelp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<overview>
<p>
Sensitive user data and system information that is logged could be seen by an attacker when it is
Sensitive user data and system information that is logged could be exposed to an attacker when it is
displayed. Also, external processes often store the standard output and standard error streams of
an application, which will include logged sensitive information.
</p>
Expand All @@ -23,7 +23,7 @@ The following example code logs user credentials (in this case, their password)
</p>
<sample src="CleartextLoggingBad.rs"/>
<p>
Instead, you should encrypt the credentials, or better still omit them entirely:
Instead, you should encrypt the credentials, or better still, omit them entirely:
</p>
<sample src="CleartextLoggingGood.rs"/>
</example>
Expand Down
2 changes: 1 addition & 1 deletion rust/ql/test/query-tests/security/CWE-312/test_logging.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use std::fmt::Write as _;
// --- tests ---

fn get_password() -> String {
return "123456".to_string();
"123456".to_string()
}

fn use_password(password: &String) {
Expand Down

0 comments on commit ed5f19b

Please sign in to comment.