Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo for new git url. #36039

Closed
wants to merge 1 commit into from
Closed

Fixed typo for new git url. #36039

wants to merge 1 commit into from

Conversation

patcon
Copy link

@patcon patcon commented Jan 23, 2025

Sorry, there was too much issue boilerplate for such a small fix, so I didn't read any of it. Thanks for understanding -- pls close if you can't merge 🙏

Copy link

welcome bot commented Jan 23, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@patcon patcon temporarily deployed to preview-env-36039 January 23, 2025 19:26 — with GitHub Actions Inactive
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 23, 2025
Copy link
Contributor

👓 Previews for changed content

This comment is 🤖 automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the review server. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/using-git/splitting-a-subfolder-out-into-a-new-repository.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server
This table is posted from the Content Changes Table Comment workflow.

@@ -71,7 +71,7 @@ If you create a new clone of the repository, you won't lose any of your Git hist
1. Add a new remote name with the URL you copied for your repository. For example, `origin` or `upstream` are two common choices.

```shell
git remote add origin https://{% data variables.product.product_url %}/USERNAME/REPOSITORY-NAME.git
git remote add origin https://{% data variables.product.product_url %}/USERNAME/NEW-REPOSITORY-NAME.git

This comment was marked as resolved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You 😘👍

Copy link

@dejadior440 dejadior440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+

@@ -71,7 +71,7 @@ If you create a new clone of the repository, you won't lose any of your Git hist
1. Add a new remote name with the URL you copied for your repository. For example, `origin` or `upstream` are two common choices.

```shell
git remote add origin https://{% data variables.product.product_url %}/USERNAME/REPOSITORY-NAME.git
git remote add origin https://{% data variables.product.product_url %}/USERNAME/NEW-REPOSITORY-NAME.git

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/get-started/using-git/splitting-a-subfolder-out-into-a-new-repository.md

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you I will figure out

@subatoi
Copy link
Contributor

subatoi commented Jan 27, 2025

Hi, I'm not sure this change is necessarily appropriate, but thank you for your interest in the docs

Please feel free to take a look at our issues marked help wanted, but I'm going to go ahead and close this one out. Thanks again!

@subatoi subatoi closed this Jan 27, 2025
@subatoi subatoi removed the triage Do not begin working on this issue until triaged by the team label Jan 27, 2025
@patcon
Copy link
Author

patcon commented Jan 27, 2025

In case the context was lost in the noise, this is the current state of the doc. It is confusing because it's misleading right now. If I didn't know git, I might be thrown off by why the "verify the remote" step shows a different url than the preceding "set the remote" step.

https://docs.github.com/en/get-started/using-git/splitting-a-subfolder-out-into-a-new-repository

Screenshot 2025-01-27 at 3 04 45 PM

I don't particularly have much stake in this game, nor do I know the contribution flow, but I would humbly suggest some improvement be made to this one line.

Anyhow, thanks for all you do!

@patcon
Copy link
Author

patcon commented Jan 27, 2025

REPOSITORY-NAME is used for the original repo further above, so it's unclear what's being suggested, if a person is new to git.

Screenshot 2025-01-27 at 3 10 21 PM

So if someone is following this contradictory advice, they might easily add the original remote, thinking that's the intention. And if they know enough about force-push to try it when they get a conflict warning, they might override their original repo, mistakenly assured earlier in the doc that the instructions on the page are guiding them through a non-destructive process.

Sorry if I'm way off-base and misunderstanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants