-
Notifications
You must be signed in to change notification settings - Fork 61k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update squash_and_merge_summary.md #36457
Conversation
Revise terminology from "original" change to "consolidated" changes to better describe what gets committed when squashing commits.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options:
A Hubber will need to deploy your changes internally to review. Table of review linksThe table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mdmower-csnw and many thanks for raising a PR and linking it to an issue — I agree that the original text is confusing, but I've suggested a different improvement which is less tied to the original text. Many thanks for your interest in the GitHub docs!
Co-authored-by: Ben Ahmady <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @mdmower-csnw! We really appreciate you taking the time to open an issue as well. I'll get this merged now.
Thanks again for your interest in the Docs!
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Revise terminology from "original" change to "consolidated" changes to better describe what gets committed when squashing commits.
Why:
The final sentence of the squash and merge summary confusingly describes squashing commits as retaining "original" changes. That isn't accurate. Consolidated changes are kept from squashing commits.
Closes: #36456
What's being changed (if available, include any code snippets, screenshots, or gifs):
Only the final sentence of the reusable squash-and-merge-summary snippet is updated.
Check off the following: